From 5c4d41c63af3ef064090336a14efe91931051e7e Mon Sep 17 00:00:00 2001
From: AidenRushbrooke <72034940+AidenRushbrooke@users.noreply.github.com>
Date: Tue, 7 Dec 2021 23:07:23 +0000
Subject: Fixed known issues

---
 src/Compiler/Expression.java |  4 ++--
 src/Compiler/Language.java   |  7 +++++++
 src/Compiler/Parser.java     | 29 +++++++++--------------------
 src/Compiler/Translator.java | 10 ++++++++--
 4 files changed, 26 insertions(+), 24 deletions(-)

(limited to 'src/Compiler')

diff --git a/src/Compiler/Expression.java b/src/Compiler/Expression.java
index 056019a..c71874b 100644
--- a/src/Compiler/Expression.java
+++ b/src/Compiler/Expression.java
@@ -140,11 +140,11 @@ abstract class Expression {
      * Class for representing a function call
      */
     static class FunctionCall extends Expression{
-        FunctionCall(Token name, List<Token> arguments){
+        FunctionCall(Token name, List<Expression> arguments){
             this.arguments=arguments;
             this.name=name;
         }
-        final List<Token> arguments;
+        final List<Expression> arguments;
         final Token name;
 
         @Override
diff --git a/src/Compiler/Language.java b/src/Compiler/Language.java
index 5013cfd..549ea29 100644
--- a/src/Compiler/Language.java
+++ b/src/Compiler/Language.java
@@ -134,6 +134,13 @@ public class Language {
         System.out.println("An error was encountered on line: "+line);
         System.out.println(message);
     }
+
+
+    static void displayError(String message){
+        hadError=true;
+        System.out.println("An error was encountered");
+        System.out.println(message);
+    }
     /**
      * Method for displaying error based on a specific token
      * @param token the token the parser detected the error on
diff --git a/src/Compiler/Parser.java b/src/Compiler/Parser.java
index 7d46063..c7b0165 100644
--- a/src/Compiler/Parser.java
+++ b/src/Compiler/Parser.java
@@ -229,14 +229,12 @@ public class Parser {
 
         //Extract the size of the array
         List<Expression> dimensions = new ArrayList<>();
-        Expression dimension = expression();
-        dimensions.add(dimension);
 
         //Extract the size of each dimension of the array
-        while(matchAndAdvance(TokenType.COMMA)){
-            dimension = expression();
+        do{
+            Expression dimension = expression();
             dimensions.add(dimension);
-        }
+        } while(matchAndAdvance(TokenType.COMMA));
 
         matchOrError(TokenType.RIGHT_PAREN, "Expected ')'");
         matchOrError(TokenType.DEFINE, ":: Required for variable definition");
@@ -519,28 +517,21 @@ public class Parser {
                 if(definedVars.containsKey(name.text)){
                     if(definedVars.get(name.text).equals("array")){
                         List<Expression> positions = new ArrayList<>();
-                        Expression position = expression();
-                        positions.add(position);
                         //Parse array positions for each dimension
-                        while(matchAndAdvance(TokenType.COMMA)){
-                            position = expression();
+                        do{
+                            Expression position = expression();
                             positions.add(position);
-                        }
+                        }while (matchAndAdvance(TokenType.COMMA));
                         matchOrError(TokenType.RIGHT_PAREN,"Expected ')'");
                         return new Expression.ArrayVariable(name, positions);
                     }
                 }
                 //If not previously declared, assume function call
-                List<Token> arguments = new ArrayList<>();
+                List<Expression> arguments = new ArrayList<>();
                 //Parse function call arguments
                 do{
-                    matchOrError(TokenType.IDENTIFIER, "Expected argument");
-                    Token argumentValue = getPreviousToken();
-                    if(definedVars.containsKey(argumentValue.text)){
-                        arguments.add(argumentValue);
-                    }else{
-                        throw error(argumentValue, "Argument undefined");
-                    }
+                    Expression argument = expression();
+                    arguments.add(argument);
                 }while(matchAndAdvance(TokenType.COMMA));
                 matchOrError(TokenType.RIGHT_PAREN, "Expected ')");
                 return new Expression.FunctionCall(name, arguments);
@@ -638,6 +629,4 @@ public class Parser {
         Language.displayError(token ,message);
         return new Error();
     }
-
-
 }
diff --git a/src/Compiler/Translator.java b/src/Compiler/Translator.java
index 6f5f050..5b7d52e 100644
--- a/src/Compiler/Translator.java
+++ b/src/Compiler/Translator.java
@@ -236,6 +236,10 @@ public class Translator{
 
         //Write each dimension of the array
         for(Expression expr:arraydec.dimensions){
+            if(expr.getExpressionType()!="literal"){
+                Language.displayError(arraydec.name, "Array sizes must be defined using constants");
+                throw new Error();
+            }
             arrayString+="[";
             arrayString+=evaluateExpression(expr);
             arrayString+="]";
@@ -293,6 +297,8 @@ public class Translator{
                 types+="%f";
             } else if (exprType.equals("string")){
                 types+="%s";
+            } else{
+                Language.displayError("Unknown expression type in print statement");
             }
             //Add the actual expression value
             values+=evaluateExpression(expr);
@@ -527,11 +533,11 @@ public class Translator{
         boolean first=true;
 
         //Write each argument of the function call
-        for(Token arg:expr.arguments){
+        for(Expression arg:expr.arguments){
             if(!first){
                 functioncall+=",";
             }
-            functioncall+=arg.text;
+            functioncall+=evaluateExpression(arg);
             first=false;
         }
         functioncall+=")";
-- 
cgit v1.2.3